Make odo compatible with NetworkX >=2.0 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass on my machine. There seems to be some problems with the TravisCI configuration that will take more time than I presently have to solve. |
|
Thanks for working on this. |
|
The changes look good to me. No one here who wants to merge it? |
|
It seems pretty clean and self-contained so I don't see any harm in merging it. |
|
Any chance we could get a new release with this? When one is cut we can unwind some of the distribution patches for this in NixPkgs and simplify our packaging config, which is always nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkX changed its API for accessing edges. This PR makes odo compatible with NetworkX 1.0/2.0 by adding a compatibility function for each version of NetworkX.
Fixes #615