Allow Profile Inheritance #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@wouterj Mind checking this? |
| $this->buildTasks($profile['tasks']); | ||
|
|
||
| if (!empty($profile['uses']) && !empty($profile['uses']['after'])) { |
There was a problem hiding this comment.
there is a library for this https://github.com/igorw/get-in we can leverage
There was a problem hiding this comment.
Don't want to add a new library for a simple !empty check...
There was a problem hiding this comment.
yeah i wouldn't either, but the import is very light, is almost a set of functions you could even copy paste if you don't like, however we keep the require because of bugfixes
There was a problem hiding this comment.
THis should be fine like this. Its a simple call
|
Changes Unknown when pulling 2b9a484 on aequasi:96-allow-profile-inheritance into * on bldr-io:master*. |
cryptiklemur
added a commit
that referenced
this pull request
Jul 24, 2014
Allow Profile Inheritance
|
This should be covered by a test :) |
|
Yeah.... >.> ill try and throw that in tonight... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sent using Gush