Skip to content

Commit

Permalink
Fix #622.
Browse files Browse the repository at this point in the history
  • Loading branch information
pablo-mayrgundter committed Feb 20, 2023
1 parent 00094c4 commit 662bf23
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bldrs",
"version": "1.0.0-r627",
"version": "1.0.0-r631",
"main": "src/index.jsx",
"license": "MIT",
"homepage": "https://github.com/bldrs-ai/Share",
Expand Down
4 changes: 2 additions & 2 deletions src/Containers/CadView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {assertDefined} from '../utils/assert'
import {handleBeforeUnload} from '../utils/event'
import {getDownloadURL, parseGitHubRepositoryURL} from '../utils/GitHub'
import SearchIndex from './SearchIndex'
import {addSceneLayer} from './SceneLayer'


/**
Expand Down Expand Up @@ -678,7 +677,8 @@ function initViewer(pathPrefix, backgroundColorStr = '#abcdef') {
v.IFC.setWasmPath('./static/js/')
v.clipper.active = true
v.clipper.orthogonalY = false
addSceneLayer(v.IFC.context)
// TODO(https://github.com/bldrs-ai/Share/issues/622): this breaks postprocessing
// addSceneLayer(v.IFC.context)

// Highlight items when hovering over them
window.onmousemove = (event) => {
Expand Down
5 changes: 4 additions & 1 deletion src/Containers/CadView.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import useStore from '../store/useStore'
import {actAsyncFlush} from '../utils/tests'
import {makeTestTree} from '../utils/TreeUtils.test'
import CadView, * as AllCadView from './CadView'
import {__getIfcViewerAPIMockSingleton} from '../../__mocks__/web-ifc-viewer'


const mockedUseNavigate = jest.fn()
Expand Down Expand Up @@ -281,6 +280,9 @@ describe('CadView', () => {
})


// TODO(https://github.com/bldrs-ai/Share/issues/622): SceneLayer breaks postprocessing
/*
import {__getIfcViewerAPIMockSingleton} from '../../__mocks__/web-ifc-viewer'
it('SceneLayer accesses IFC camera, renderer and scene camera', async () => {
const modelPath = {
filepath: `/index.ifc`,
Expand All @@ -298,4 +300,5 @@ describe('CadView', () => {
expect(viewerMock.IFC.context.getScene).toHaveBeenCalled()
await actAsyncFlush()
})
*/
})

0 comments on commit 662bf23

Please sign in to comment.