Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint fixes #101

Merged
merged 63 commits into from Feb 15, 2022
Merged

Eslint fixes #101

merged 63 commits into from Feb 15, 2022

Conversation

OlegMoshkovich
Copy link
Member

No description provided.

Oleg and others added 30 commits December 8, 2021 17:59
new build;
311628f
add build
ddd8376
another build
e6b1c13
resolve conflicts
2d9e720
new build
8994713
Merge remote-tracking branch 'upstream/main'
5f2587f
Merge branch 'main' of https://github.com/buildrs/Share
84e44b1
Merge branch 'main' of https://github.com/buildrs/Share
df47657
merged yarn test
1f7a7e3
correct build
afb08f5
pull form upstream
6990702
properties update
200f4d4
Merge branch 'main' of https://github.com/buildrs/Share
d676807
Merge branch 'main' of https://github.com/buildrs/Share
662c050
Merge branch 'main' of https://github.com/buildrs/Share
28b76ee
update
e17b1dd
Merge branch 'main' of https://github.com/buildrs/Share
d03465f
Merge branch 'main' of https://github.com/buildrs/Share
21b9f33
assets
a834a69 
update about

fix the toolbar

details
@OlegMoshkovich
Merge pull request #2 from OlegMoshkovich/about_clone
754222c 
about
build
15d4b49
build
335a612
change the logo
be0cdb3
add abstracted logo
3c7445a
added 3D theme
bafc605
new build
ac90bed
add the icons
667b6b2
update icons
3c0f433
pass tests
1005fbd
tst description
ea17b3d
pablo-mayrgundter
pablo-mayrgundter requested changes Feb 14, 2022
View reviewed changes
src/Components/AboutPanel.jsx Outdated Show resolved Hide resolved
src/Components/NavPanel.jsx Show resolved Hide resolved
src/utils/Ifc.js Show resolved Hide resolved
src/utils/TreeUtils.js Show resolved Hide resolved
src/utils/TreeUtils.js Show resolved Hide resolved
src/utils/TreeUtils.test.js Show resolved Hide resolved
pablo-mayrgundter
pablo-mayrgundter requested changes Feb 14, 2022
View reviewed changes
src/Containers/SearchIndex.js Outdated Show resolved Hide resolved
src/Containers/SearchIndex.js Outdated Show resolved Hide resolved
src/Containers/SearchIndex.js Show resolved Hide resolved
src/utils/Ifc.js Show resolved Hide resolved
src/utils/TreeUtils.js Outdated Show resolved Hide resolved
pablo-mayrgundter
pablo-mayrgundter reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the one debug log then I think you have to merge in the hotfix to main from earlier and let's click around testing a lot.

Oleg and others added 11 commits February 14, 2022 22:47
console fix
61b9067
build
b27f1eb
build
710a1b3
Merge branch 'main' of https://github.com/buildrs/Share
4260848
resolve errors
243d49a 
fix docs in search, ifc and tree utils

fix react component etc

fix utils

fix the comments

fix spacing

fix the tests

more fixes

add export default

fix lint errors

fix ifc errors

add the errors

es lint warnings

fix

buid

fix errors in the icon group

console fix

build

build
@OlegMoshkovich
Merge pull request #3 from OlegMoshkovich/es-lint
5bf1115 
Es lint
merge fixes
7718f85
fix the lint errors
34095f8
add yarn lint rules
0182d6d
resolved conflicts from main
f128be5
add styles to item properties
b95442b
pablo-mayrgundter
pablo-mayrgundter requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .eslintirgnore since it's empty. Probably won't need it.

src/BaseRoutes.jsx Outdated Show resolved Hide resolved
src/Components/GuidePanel.jsx Outdated Show resolved Hide resolved
src/Components/GuidePanel.jsx Outdated Show resolved Hide resolved
src/Components/GuidePanel.jsx Outdated Show resolved Hide resolved
src/Components/GuidePanel.jsx Show resolved Hide resolved
src/Components/ItemProperties.jsx Outdated Show resolved Hide resolved
src/Components/ItemProperties.test.jsx Show resolved Hide resolved
src/Share.jsx Outdated Show resolved Hide resolved
src/utils/TreeUtils.js Outdated Show resolved Hide resolved
@pablo-mayrgundter
Copy link
Member

Looks great! Welcome to the love of eslint! ;)

@pablo-mayrgundter pablo-mayrgundter merged commit 16df4a3 into bldrs-ai:main Feb 15, 2022
@OlegMoshkovich OlegMoshkovich deleted the es-lint branch February 20, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
bldrs.ai
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlegMoshkovich @pablo-mayrgundter