Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle all property accordions #111

Merged
merged 86 commits into from Feb 19, 2022
Merged

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Feb 19, 2022

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Components/ItemProperties.jsx Outdated Show resolved Hide resolved
src/Components/ItemProperties.jsx Outdated Show resolved Hide resolved
src/Components/ItemProperties.jsx Outdated Show resolved Hide resolved
src/Components/ItemProperties.jsx Outdated Show resolved Hide resolved
src/Components/ItemProperties.jsx Outdated Show resolved Hide resolved
src/Components/ExpansionPanel.jsx Outdated Show resolved Hide resolved
import ExpandIcon from '../assets/ExpandIcon.svg'


/** Expansion panels are used to package property sets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**
 * Expansion panels are used to package property sets
 * @param {string} detail title of the panel
 * @param {string} summary content of the panel
 * @param {boolean} expandState global control of the panel
 * @param {Object} classes styles for the panel
 * @return {Object}
 */

* @return {Object}
*/
export default function Property({detail, summary, expandState, classes}) {
useEffect(()=>setExpand(expandState), [expandState])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useEffect(() => setExpand(expandState), [expandState])

<Accordion
className={classes.accordian}
expanded={expand === true}
onChange={()=>setExpand(!expand)}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onChange={() => setExpand(!expand)}>

<h2 className = {classes.sectionTitle}>Property Sets</h2>
<h2 className={classes.sectionTitle}>
<div>Property Sets</div>
<Toggle onChange={()=>setExpandAll(!expandAll)} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Toggle onChange={() => setExpandAll(!expandAll)} />

</Accordion>
<li key={ndx} className={classes.section}>
<ExpansionPanel
summary={decodeIFCString(ps.Name.value)||'Property Set'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary={decodeIFCString(ps.Name.value) || 'Property Set'}

@pablo-mayrgundter pablo-mayrgundter merged commit 2cca641 into bldrs-ai:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants