Adjust styles for mobile #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Only issue is that the click-on-logo takes you to the desktop camera, not the mobile. To get desktop users back to desktop camera and mobile back to mobile camera I think you should call Share.jsx#navToDefault |
|
ok got it. |
|
Hm, I see a couple issues. On mobile, I'm getting a broken About button:
I don't see this on web, but related, the SVG you're using has hard-coded background white disc and fill colors. Please remove these and test with varying themes. |
pablo-mayrgundter
requested changes
Mar 12, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://olegmoshkovich.github.io/Share/share/v/p/index.ifc#c:-111.37,14.94,90.63,-43.48,15.73,-4.34