Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtag fix #151

Merged
merged 4 commits into from Mar 15, 2022
Merged

Gtag fix #151

merged 4 commits into from Mar 15, 2022

Conversation

OlegMoshkovich
Copy link
Member

Replace deleted arguments in gtag method.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad. Could you also include a unit test? In gtag.test.js something like:

test('gtag', () => {
  let args = null
  window.dataLayer = {
    push: (a) => {
      args = a
    }
  }
  gtag('a', 'b')
  expect(args).toBe(['a', 'b'])
})

@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL

@pablo-mayrgundter pablo-mayrgundter merged commit 90306d5 into bldrs-ai:main Mar 15, 2022
@OlegMoshkovich OlegMoshkovich deleted the analytics branch April 4, 2022 09:30
@oo-bldrs oo-bldrs changed the title Analytics: Gtag fix Gtag fix Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants