Item props refresh #155
Merged
Item props refresh #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOBILE_WIDTH preprocessing for styles.
|
|
src/Components/ItemProperties.jsx
Outdated
| }, | ||
| '& h2': { | ||
| fontSize: '1.1em', | ||
| fontWeight: 800, |
There was a problem hiding this comment.
this seems to much - keep it at 600 - maybe.
There was a problem hiding this comment.
Yeah, gave it a try but doesn't go between.. it's either thin or heavy, at least for me... give this a try.
src/Components/MobileDrawer.jsx
Outdated
| swipeAreaWidth={drawerBleeding} | ||
| disableSwipeToOpen={false}> | ||
| <StyledBox className={classes.contentContainer}> | ||
| <Puller onClick={toggleDrawer}/> |
There was a problem hiding this comment.
As we discusses - replace with up/down arrows.
https://www.figma.com/file/KDQmXLUP8nmw0RjxXRBBW2/BLDRS-assets?node-id=762%3A9
There was a problem hiding this comment.
My net can't take figma right now :( I think this is as discussed tho... lmk!
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ItemProperties changes:
Partially addresses the content visibility in #148. Properties are now header+text instead of table. Also mobile has full-screen toggle.
esbuild: