Cookies fix #159
Merged
Cookies fix #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
OlegMoshkovich
commented
Mar 22, 2022
OlegMoshkovich
commented
- fix get cookies
- fix privacy slider
pablo-mayrgundter
requested changes
Mar 22, 2022
OlegMoshkovich
force-pushed
the
cookies-fix
branch
from
800442b
to
a552a73
Compare
|
|
@pablo-mayrgundter PTAL! |
|
Please include link to your demo in the description |
|
@pablo-mayrgundter PTAL. |
src/privacy/analytics.js
Outdated
| */ | ||
| export function isAnalyticsAllowed() { | ||
| return Functional.getCookieBoolean('isAnalyticsAllowed', false) // defaultValue | ||
| return Privacy.isPrivacySocialEnabled() // defaultValue |
fix getCookie fix is Analytics allowed debuggin analytics - subtract isAllowed consitional add the debug built add privacy test refactor privacy function out of the about control space clean up refactor is analytics allowed method
OlegMoshkovich
force-pushed
the
cookies-fix
branch
from
5c3eada
to
0204019
Compare
|
@pablo-mayrgundter |
OlegMoshkovich
added a commit
to OlegMoshkovich/Share
that referenced
this pull request
Apr 27, 2022
* fix privacy slider fix getCookie fix is Analytics allowed debuggin analytics - subtract isAllowed consitional add the debug built add privacy test refactor privacy function out of the about control space clean up refactor is analytics allowed method * new build * add is privacy social and usage enabled * additional test for privacy * clean up * new build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.