Extend search bar functionality to open IFCs hosted on GitHub. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegMoshkovich
changed the title
OlegMoshkovich
force-pushed
the
search_URL
branch
from
33b4521
to
31faac1
Compare
pablo-mayrgundter
requested changes
Apr 13, 2022
OlegMoshkovich
force-pushed
the
search_URL
branch
from
3e088a9
to
b88403e
Compare
|
The link should work now. GitHub model hosting: @pablo-mayrgundter PTAL. |
|
@pablo-mayrgundter PTAL! |
OlegMoshkovich
commented
Apr 15, 2022
pablo-mayrgundter
requested changes
Apr 15, 2022
pablo-mayrgundter
requested changes
Apr 15, 2022
|
I accidentally pushed my changes to your fork&branch (a lot of that lately! 🫣) but I think we like it? Will wait to hear back your comments |
OlegMoshkovich
commented
Apr 20, 2022
OlegMoshkovich
commented
Apr 20, 2022
OlegMoshkovich
commented
Apr 20, 2022
OlegMoshkovich
commented
Apr 20, 2022
|
Heya, I'm leaving for the weekend tomorrow so in the interest of time going to merge. You said you were good and just had those comments. I did update to handle more types of links in looksLikeLink and then answered the other questions. So I think everything is addressed. |
OlegMoshkovich
added a commit
to OlegMoshkovich/Share
that referenced
this pull request
Apr 27, 2022
…-ai#174) * add a method to check if the input is URL * rename * extract url parameters from search input * debug the model path * add styles and funcitons to the search bar * moved url methods to share routes * new build * new build * add test to share routes * add test to share routes * add test to share routes * fixes * add tests + parse url method * add isURL and error messaging * clean up * clean up * add fixes * fixes * search: thoughts on how to use regex capture group for github url parsing * search: support both full URLs and paths in search. * search: More case handling for load-by-link in searchbar. * search: little more refactoring and test cases. Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://olegmoshkovich.github.io/Share/share/v/gh/Swiss-Property-AG/Portfolio/main/EISVOGEL.ifc