Sample models #187
Merged
Sample models #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! Ready for review? Please add a unit test that checks the element renders. |
OlegMoshkovich
commented
May 4, 2022
| headerText='Model Access' | ||
| isDialogDisplayed={isDialogDisplayed} | ||
| setIsDialogDisplayed={setIsDialogDisplayed} | ||
| content={ | ||
| <div className={classes.content}> | ||
| <LocalFileOpen/> | ||
| <GitHubIcon style = {{width: '50px', height: '50px'}}/> |
There was a problem hiding this comment.
Need to use inline styles here.
We are styling all of the svgs in the dialog which over writes the class styles.
OlegMoshkovich
commented
May 4, 2022
OlegMoshkovich
added a commit
to OlegMoshkovich/Share
that referenced
this pull request
May 19, 2022
* add sample models Dialog * add sample model * add description to the sample model dialog * adjust shortcut models * clean up * clean up * add test + style details * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://olegmoshkovich.github.io/Share/share/v/p/index.ifc#c:-111.37,14.94,90.63,-43.48,15.73,-4.34