Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zustand #228

Merged
merged 9 commits into from Jun 17, 2022
Merged

Zustand #228

merged 9 commits into from Jun 17, 2022

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Jun 17, 2022

Add Zustand Global state container.
Connect Snack Bar message to zustand.
Add Snack Message zustand test.

https://olegmoshkovich.github.io/Share/share/v/p/index.ifc#c:-144.36,14.11,147.82,-40.42,17.84,-2.28

@netlify
Copy link

netlify bot commented Jun 17, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit a8ca28f
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62ac8ae01e860f0009bab8a3
😎 Deploy Preview https://deploy-preview-228--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe consider splitting the big state object into slices. https://github.com/pmndrs/zustand/wiki/Splitting-the-store-into-separate-slices

src/Containers/CadView.jsx Outdated Show resolved Hide resolved
@OlegMoshkovich OlegMoshkovich merged commit 0671471 into bldrs-ai:main Jun 17, 2022
@OlegMoshkovich OlegMoshkovich self-assigned this Jun 17, 2022
@OlegMoshkovich OlegMoshkovich added the collab Collaboration Requirements label Jun 17, 2022
@OlegMoshkovich OlegMoshkovich deleted the zustand branch September 20, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collab Collaboration Requirements
Projects
No open projects
Status: Done
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants