Add Issues/Notes #235
Add Issues/Notes #235
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Really nice to see this :) Per conversation:
|
|
Morning! Addressed the store reset and the mobile drawer issues. |
|
@pablo-mayrgundter PTAL |
add ifc slice to the store add ifc slice state properties to cadview add select IFC element test add viewer test add viewer test new build add ifc slice clean up clean up add side drawer new build Add sideDrawer to cadView clean up add properties panel to the side drawer add hightlight color to the theme delete item panel drawer add item properties test clean up clean up clean up fix mobile drawer clean up styles refactor title out of the side drawer panel resolve comments add issue card + rewire issue control add camera control rewire operations group rewire operations group add Issue Slice to the store and connect it to operations group add issue panel style side Drawer testing drawer on the top show small image on mobile new build drawer style on mobile drawer styles style mobile drawer reset element state on model style style fix camera clean up add camera controls new build addressed comments new build resolve comments fixes
|
@pablo-mayrgundter addressed everything - besides 'spaces never' - I think. |
|
@pablo-mayrgundter PTAL |
| /** The prefix to use for issue id in the URL hash. */ | ||
| export const ISSUE_PREFIX = 'i' | ||
| useEffect(() => { | ||
| const fetchIssues = async () => { |
There was a problem hiding this comment.
Please add:
// TODO(pablo): refactor issues fetch logic into Issues.js
|
Please add the one TODO comment I noted, then all good! |
|
Actually, I want to base some changes off of this so will merge now and add the todo. |
No description provided.