Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection container to the card #260

Merged
merged 2 commits into from Jul 13, 2022

Conversation

OlegMoshkovich
Copy link
Member

To improve the UI added a selection container/wrapper around the title and the image regions of the card.

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 6f95a71
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62ce88abfe54ac0008023d3c
😎 Deploy Preview https://deploy-preview-260--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

expandText={expandText}
onClick={(event) => {
event.preventDefault()
expandText ? setExpandText(false) : setExpandText(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace line with:

setExpandText(!expandText)

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line change, then pls submit. I've cherry-picked against my PR and shouldn't get any conflicts.

@OlegMoshkovich OlegMoshkovich merged commit f6a1a59 into bldrs-ai:main Jul 13, 2022
pablo-mayrgundter added a commit that referenced this pull request Jul 13, 2022
pablo-mayrgundter added a commit that referenced this pull request Jul 13, 2022
* GitHub issues requests now require explicit org and repo names.  Introduce RepositorySlice to store and use default of pablo-mayrgundter/Share during transition.  Refactor unit tests to include default repo for testing.  Upgrade jest and json to attemp to clean up debug logging in testing output.

* issues: cherrypick #260 in prep for merge.
pablo-mayrgundter added a commit that referenced this pull request Jul 13, 2022
* GitHub issues requests now require explicit org and repo names.  Introduce RepositorySlice to store and use default of pablo-mayrgundter/Share during transition.  Refactor unit tests to include default repo for testing.  Upgrade jest and json to attemp to clean up debug logging in testing output.

* issues: cherrypick #260 in prep for merge.
@OlegMoshkovich OlegMoshkovich deleted the noteSelection branch July 13, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants