New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selection container to the card #260
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
expandText={expandText} | ||
onClick={(event) => { | ||
event.preventDefault() | ||
expandText ? setExpandText(false) : setExpandText(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace line with:
setExpandText(!expandText)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One line change, then pls submit. I've cherry-picked against my PR and shouldn't get any conflicts.
* GitHub issues requests now require explicit org and repo names. Introduce RepositorySlice to store and use default of pablo-mayrgundter/Share during transition. Refactor unit tests to include default repo for testing. Upgrade jest and json to attemp to clean up debug logging in testing output. * issues: cherrypick #260 in prep for merge.
* GitHub issues requests now require explicit org and repo names. Introduce RepositorySlice to store and use default of pablo-mayrgundter/Share during transition. Refactor unit tests to include default repo for testing. Upgrade jest and json to attemp to clean up debug logging in testing output. * issues: cherrypick #260 in prep for merge.
To improve the UI added a selection container/wrapper around the title and the image regions of the card.