New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset the comments state when the next note is selected -- #257 #266
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Heya, I'm not seeing this in prod anymore, but I'm also seeing the side panel close when I click on comments, but only sometimes. Not really sure what the state of prod is atm. |
Not sure what this is fixing then.. "This PR addresses the issue state slice -, particularly the comments portion." I don't follow. Sidebar disappears when I click on second comment to an issue. Also, the green highlight on the comments button shows up when comments are inactive, but I think you want it when they're active. Let's do a call if this is getting confusing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablo-mayrgundter left descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems all concerns were addressed and the PR is ready to be merged.
correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Go ahead :)
No description provided.