Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the comments state when the next note is selected -- #257 #266

Merged
merged 31 commits into from Jul 22, 2022

Conversation

OlegMoshkovich
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 8e54570
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62da92a4a7c7ac0008f3a2f2
😎 Deploy Preview https://deploy-preview-266--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pablo-mayrgundter
Copy link
Member

Heya, I'm not seeing this in prod anymore, but I'm also seeing the side panel close when I click on comments, but only sometimes. Not really sure what the state of prod is atm.

@pablo-mayrgundter
Copy link
Member

Not sure what this is fixing then.. "This PR addresses the issue state slice -, particularly the comments portion." I don't follow.

Sidebar disappears when I click on second comment to an issue.

Also, the green highlight on the comments button shows up when comments are inactive, but I think you want it when they're active.

Let's do a call if this is getting confusing

Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablo-mayrgundter left descriptions.

src/Components/IssuesControl.jsx Show resolved Hide resolved
src/store/IssuesSlice.js Show resolved Hide resolved
src/utils/GitHub.js Show resolved Hide resolved
src/Components/IssuesControl.jsx Outdated Show resolved Hide resolved
src/Components/OperationsGroup.jsx Outdated Show resolved Hide resolved
src/Components/SampleModelsControl.jsx Show resolved Hide resolved
@bldrs-ai bldrs-ai deleted a comment from pablo-mayrgundter Jul 22, 2022
Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems all concerns were addressed and the PR is ready to be merged.
correct?

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Go ahead :)

@OlegMoshkovich OlegMoshkovich merged commit 32258b7 into bldrs-ai:main Jul 22, 2022
@OlegMoshkovich OlegMoshkovich deleted the repliesState branch September 27, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants