Markdown & Project links #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new es6 module deps were introduced, which prompted a new approach for jest config. Not sure how best to handle this but works for now.
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Note the italics in the comment.. these are driven by markdown. |
…s suffix imported icons with "Icon". Remove defunct ShareMenu.jsx
|
I've also setup a test issue that demonstrates a link to another project (KNIK): See the third comment. You can click on KNIK. Link isn't styled.. working on that now. |
|
@pablo-mayrgundter the url is used for the camera view on line 75 and 89 here: |
OlegMoshkovich
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Oleg,
Here's a first cut at Markdown support (#273). Posting as a draft to validate against live github issues on our home project.
I would appreciate any pointers you can give me for where an embedded URL is being handled such that clicking on it doesn't lead to the full project path.