Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling of embedded images and links. #289

Merged
merged 11 commits into from Aug 2, 2022

Conversation

pablo-mayrgundter
Copy link
Member

Fix for #286.

Draft until I figure how to restore camera link support.

@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 16e1cf1
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62e8bf65ad409100083c5e66
😎 Deploy Preview https://deploy-preview-289--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review July 27, 2022 18:28
@OlegMoshkovich OlegMoshkovich marked this pull request as draft July 28, 2022 13:48
@pablo-mayrgundter pablo-mayrgundter marked this pull request as ready for review August 1, 2022 19:24
@pablo-mayrgundter
Copy link
Member Author

pablo-mayrgundter commented Aug 1, 2022

Yay, pretty markdown images

https://deploy-preview-289--bldrs-share.netlify.app/share/v/gh/Swiss-Property-AG/Portfolio/main/KNIK.ifc#i:1303236877

image

@OlegMoshkovich
Copy link
Member

OlegMoshkovich commented Aug 1, 2022

awesome.
The image of the galaxy is not there anymore.
image

@pablo-mayrgundter
Copy link
Member Author

Right, the comments in main are in the old format. When this change goes live I'll edit them to use markdown instead.

@pablo-mayrgundter pablo-mayrgundter merged commit ad7b839 into bldrs-ai:main Aug 2, 2022
@pablo-mayrgundter pablo-mayrgundter deleted the comment-text branch August 2, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants