Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StoryBook: OpenDialog #290

Merged
merged 11 commits into from Jul 29, 2022
Merged

StoryBook: OpenDialog #290

merged 11 commits into from Jul 29, 2022

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Jul 28, 2022 •
edited

PR contains:

  • Rectangular button
  • OpenDialog
  • Rectangular variant theme adjustment
  • Open Dialog Header Content
  • Open Dialog Body Content
  • Dialog Stories

@netlify
Copy link

netlify bot commented Jul 28, 2022 •
edited

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 2cd45fd
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62e404e48da6e5000909abb1
😎 Deploy Preview https://deploy-preview-290--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OlegMoshkovich OlegMoshkovich marked this pull request as draft July 28, 2022 14:29
@pablo-mayrgundter pablo-mayrgundter changed the title DRAFT: StoryBook: OpenDialog StoryBook: OpenDialog Jul 28, 2022
@pablo-mayrgundter
Copy link
Member

You should be able to merge now and get a live hosted CB for review.

OlegMoshkovich
OlegMoshkovich commented Jul 29, 2022
View reviewed changes
Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablo-mayrgundter -- please let me know if it is ok to merge.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review July 29, 2022 16:03
pablo-mayrgundter
pablo-mayrgundter approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some syntax cleanups but otherwise lgtm!

Nice to see live in SB :)

src/Components/Dialog_redesign.jsx Show resolved Hide resolved
src/Components/Dialog_redesign.jsx Show resolved Hide resolved
src/Components/InputBar.jsx Show resolved Hide resolved
src/Components/InputBar.jsx Show resolved Hide resolved
src/stories/buttons/RectangularButton.stories.jsx Show resolved Hide resolved
src/stories/buttons/RectangularButton.stories.jsx Show resolved Hide resolved
src/stories/input/Input.stories.jsx Show resolved Hide resolved
@OlegMoshkovich OlegMoshkovich merged commit 81aa75a into bldrs-ai:main Jul 29, 2022
@pablo-mayrgundter pablo-mayrgundter added the code Code cleanup, refactoring, style and lint label Aug 2, 2022
@OlegMoshkovich OlegMoshkovich deleted the OpenDialog branch September 27, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter approved these changes

Assignees

@OlegMoshkovich OlegMoshkovich

Labels
code Code cleanup, refactoring, style and lint
Projects
No open projects
bldrs.ai
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlegMoshkovich @pablo-mayrgundter