storybook: add SB to serving and use esbuild for it. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Not sure why the netlify link goes to /sb now.. i'll try to fix that up. |
|
Also, a follow-on for this is maybe add /docs to our .gitignore so we are sure we stop checking it in. |
OlegMoshkovich
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes new build rules and slight change in how we build.
Storybook can now be accessed at our Netlify and bldrs.ai by appending /sb to the host. I'll add a link when this PR builds.
Usually yarn serve will build, but it wiped out the existing serving directory and rebuilt it. I tried this with storybook, but SB takes a long time to build and it doesn't hot serve.
Documented the updated package scripts here:
https://github.com/bldrs-ai/Share/wiki/Dev:-Guide#package-scripts