Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notes drawer styles #308

Merged
merged 22 commits into from Aug 4, 2022
Merged

notes drawer styles #308

merged 22 commits into from Aug 4, 2022

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Aug 3, 2022 •
edited by pablo-mayrgundter

Address the following issues:
#304
part of this issue
#306

Adjusted:

  • Notes panel NavBar
  • Note card

@netlify
Copy link

netlify bot commented Aug 3, 2022 •
edited

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit a364fe4
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62ebfa03eb1fea0009ab08d5
😎 Deploy Preview https://deploy-preview-308--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter please take a look

@pablo-mayrgundter
Copy link
Member

Looking better! There's a problem with paging.. load KNIK and then page issues.. you can get to 3/4 but not to 4/4.

@pablo-mayrgundter
Copy link
Member

Mobile (iPhone12) looks to have too much padding..

image

pablo-mayrgundter
pablo-mayrgundter requested changes Aug 3, 2022
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/docs directory shouldn't be part of this or future PRs. Did you sync to head to create this branch? Might want to restart it..

@pablo-mayrgundter
Copy link
Member

This looks like it's pulling in Markus's proposal to remove metadata.

Could you list in the description which issues you're addressing with this PR?

I don't agree with that change.. I think it's right for smth like Portfolio mode when we have that, but in general I think it helps orient the user that these are indeed comments to see the usual metadata.

@pablo-mayrgundter
Copy link
Member

How about omiting the pager when there's only a single issue?
image

@bldrs-ai bldrs-ai deleted a comment from OlegMoshkovich Aug 4, 2022
@pablo-mayrgundter
Copy link
Member

Did left padding grow? I thought this was left-aligned with "Notes" before..
image

@OlegMoshkovich
Copy link
Member Author

image

image

@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL

pablo-mayrgundter
pablo-mayrgundter approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One change for unit tests.. looks like you removed the assert for username in previous change, but should be back now. Added comment below...

src/Components/IssueCard.test.jsx Outdated Show resolved Hide resolved
src/Components/IssuesControl.jsx Outdated Show resolved Hide resolved
@OlegMoshkovich OlegMoshkovich merged commit b299ac0 into bldrs-ai:main Aug 4, 2022
@OlegMoshkovich OlegMoshkovich deleted the Notes_styles branch September 20, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
bldrs.ai
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlegMoshkovich @pablo-mayrgundter