Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove url camera clear on component load. (restarting PR from post-lint fix). #328

Merged
merged 7 commits into from Aug 12, 2022

Conversation

pablo-mayrgundter
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter commented Aug 10, 2022

This PR is first in a series to address #313. This restores URL issue status handling based on the conversation there.

Demo by clicking on preview link and just open issues panel. It shouldn't remove camera from URL.

Based on #324.

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 06908a9
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62f5fe0da8ecfc0008230fd0
😎 Deploy Preview https://deploy-preview-328--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pablo-mayrgundter pablo-mayrgundter self-assigned this Aug 10, 2022
@pablo-mayrgundter pablo-mayrgundter added the bug Something isn't working label Aug 10, 2022
Copy link
Member

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablo-mayrgundter do you know why lint fixes are a part of the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Status: Completed
Development

Successfully merging this pull request may close these issues.

Bug: Element selection only works if tree view is open
2 participants