Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property set scrolling #333

Merged
merged 1 commit into from Aug 19, 2022

Conversation

OlegMoshkovich
Copy link
Member

  • This pr addresses scrolling for the psets, previously the psets in the expanded view did not scroll all the way.
  • Change mobile drawer to full height when it is initially opened.

@netlify
Copy link

netlify bot commented Aug 16, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 3b25596
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/62ffb5cf9b9cd10008964cc9
😎 Deploy Preview https://deploy-preview-333--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pablo-mayrgundter pablo-mayrgundter added the bug Something isn't working label Aug 16, 2022
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got an unexpected file included in this

src/utils/cutPlane.js Outdated Show resolved Hide resolved
@OlegMoshkovich
Copy link
Member Author

removed. PTAL

connect cut plane functionality to the button

fix property section is not scrolling all of the way

revert operations group back to original

remove cutplane.js
@OlegMoshkovich OlegMoshkovich merged commit bce2c15 into bldrs-ai:main Aug 19, 2022
@OlegMoshkovich OlegMoshkovich deleted the mobile_scroll branch September 20, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants