Toggle scene size when drawer expanded; desktop only. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
On mobile when the draw is opened the scene turns blank |
|
Whoops! Didn't push everything. PTAL |
|
great! |
OlegMoshkovich
approved these changes
Aug 17, 2022
OlegMoshkovich
requested changes
Aug 17, 2022
| @@ -459,6 +475,9 @@ function initViewer(pathPrefix, backgroundColorStr = '#abcdef') { | |||
| } | |||
| } | |||
|
|
|||
| // window.addEventListener('resize', () => {v.context.resize()}) | |||
|
Damn, didn't push after removed the comment. Will do it in next pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we had an issue filed for this, but it came up in discussion.. now that the drawer is bigger the content is obscured. This gives the same centered view when drawer is open or closed.
Desktop only.