Notes: load shared note based on the url parameter #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
OlegMoshkovich
changed the title
|
Is this description correct? Not sure what this is doing.. isn't it handling clearing behavior? |
1 similar comment
|
Is this description correct? Not sure what this is doing.. isn't it handling clearing behavior? |
OlegMoshkovich
changed the title
|
@pablo-mayrgundter PTAL. |
|
Hi, can you merge and now try a test for this? |
OlegMoshkovich
force-pushed
the
noteLink
branch
from
83efdff
to
9341db8
Compare
OlegMoshkovich
commented
Aug 31, 2022
pablo-mayrgundter
approved these changes
Sep 2, 2022
OlegMoshkovich
force-pushed
the
noteLink
branch
from
281d247
to
5770717
Compare
OlegMoshkovich
added a commit
to OlegMoshkovich/Share
that referenced
this pull request
Sep 5, 2022
* test issue number in the url * add the logging for the extracted id * debug the selection from the url parameter * add logging to the side drawer * move the logic for clearing the note to the side drawer * subtract drawer open dependency from the drawer * fix the logic in the useEffect * clean up * add side drawer issue body test * fix the test * clean up * debug side drawer open comments use effect
|
Heya, let's try to avoid significant mods after Approval without another round of review. What ended up happening? Looks like the test for this got removed? |
|
I thought you approved it. |
|
Per discussion, please restore test in a new PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #314.
SideDrawer useEffect clears the issue number and moves the navpanel to the list view. .