Viewer: Change selected and preselected colors #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
OlegMoshkovich
force-pushed
the
Viewer-onHover_color
branch
from
18f1eea
to
f1e1db9
Compare
|
@pablo-mayrgundter PTAL. |
|
Code looks good but I can barely see the active selection anymore. Can you increase contrast? I wonder too maybe it's because I'm a little color-blind so color choice might matter. Would be nice to have it easily visible with low screen brightness too; currently not visible if I go to half brightness on my monitor. |
|
Yes sure. there is opacity on the color at the moment - will remove. |
|
@pablo-mayrgundter how about this? |
OlegMoshkovich
force-pushed
the
Viewer-onHover_color
branch
from
f1e1db9
to
f259ede
Compare
|
@pablo-mayrgundter PTAL |
pablo-mayrgundter
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #334.
It defines custom colors for viewer select and preselect interaction, using theme custom palette colors.