Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Property window is cropped #354

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Bug: Property window is cropped #354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22cc559
fix properties cropped window
OlegMoshkovich Aug 25, 2022
9fa2b2f
Merge branch 'main' into UI-Property_window
OlegMoshkovich Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Components/ItemProperties.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,11 @@ const useStyles = makeStyles((theme) => ({
psetsList: {
padding: '0px',
margin: 0,
height: '370px',
minHeight: '370px',
height: '100%',
overflow: 'scroll',
width: '100%',
flexGrow: 1,
},
section: {
'listStyle': 'none',
Expand Down
4 changes: 2 additions & 2 deletions src/Components/SideDrawer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ const useStyles = makeStyles((props) => (preprocessMediaQuery(MOBILE_WIDTH, {
},
},
content: {
'overflow': 'hidden',
'overflow': 'scroll',
'height': '95%',
'marginTop': '20px',
'display': 'flex',
Expand All @@ -187,7 +187,7 @@ const useStyles = makeStyles((props) => (preprocessMediaQuery(MOBILE_WIDTH, {
borderRadius: '5px',
overflow: 'hidden',
display: (p) => p.isPropertiesOn ? '' : 'none',
height: (p) => p.isCommentsOn ? '50%' : '1200px',
height: (p) => p.isCommentsOn ? '50%' : '98%',
},
divider: {
height: '1px',
Expand Down
14 changes: 11 additions & 3 deletions src/Components/SideDrawerPanels.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function PropertiesPanel() {
</div>
}
/>
<div className={classes.contentContainer}>
<div className={classes.contentContainerProperties}>
{selectedElement ? <ItemProperties/> : null}
</div>
</>
Expand All @@ -62,7 +62,7 @@ export const NotesPanel = () => {
return (
<>
<IssuesNavBar/>
<div className={classes.contentContainer}>
<div className={classes.contentContainerNotes}>
<Issues/>
</div>
</>
Expand All @@ -89,14 +89,22 @@ const useStyles = makeStyles((theme) => ({
paddingLeft: '2px',
alignItems: 'center',
},
contentContainer: {
contentContainerProperties: {
marginTop: '4px',
display: 'flex',
flexDirection: 'column',
alignItems: 'center',
height: '100%',
overflow: 'scroll',
},
contentContainerNotes: {
marginTop: '4px',
display: 'flex',
flexDirection: 'column',
alignItems: 'center',
height: '100%',
overflow: 'auto',
},
controls: {
height: '100%',
display: 'flex',
Expand Down