Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Plan View #364

Merged
merged 29 commits into from Oct 6, 2022
Merged

Toggle Plan View #364

merged 29 commits into from Oct 6, 2022

Conversation

mkeshavarzi
Copy link
Contributor

@mkeshavarzi mkeshavarzi commented Aug 31, 2022

Branched from #356.

Create UI button (inside ExtractLevels menu or outside) allowing the user to toggle between perspective and plan view.

Reflects #246

OlegMoshkovich and others added 7 commits August 23, 2022 12:57
add extract hash direction from the url

add a check

move the ifcjs library version back to the latest

debugging plane hash

testing cut plane use effect

move plane creating logic into the use effect

debugging the model in the useEffect

debugging the model in the useEffect

subtract dependencies from the useEffect

add model check

add logs to the useEffect

subtract creating plane

use effect debug

working on the plane in the link direction

return the vector to enable cutplane

change the y normal direction

clean up

clean up cutPlane menu

deleted unused functions from the cutplane utility

address order of imports

clean up the cut plane utility

clean up

introduce toggle to the plane menu

clean up

calibrate normals agains the sp buildings
Demo for EISVOGEL.ifc. Integration with calLevSec.js in ifctool needed.
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 8b8736d
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/632c2686728ccb00098f75e9
😎 Deploy Preview https://deploy-preview-364--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mkeshavarzi mkeshavarzi marked this pull request as draft August 31, 2022 00:04
@mkeshavarzi mkeshavarzi marked this pull request as ready for review September 21, 2022 07:40
@pablo-mayrgundter
Copy link
Member

Hi Mohammed, I lost track a little. I thought I reviewed this PR, but don't see my comments. I had noted things like the console.logs should be removed. Do you remember that? Could you point me to that PR?

@pablo-mayrgundter
Copy link
Member

I see this PR, #356 and #394. Can you summarize how they're related?

@mkeshavarzi
Copy link
Contributor Author

Hi Mohammed, I lost track a little. I thought I reviewed this PR, but don't see my comments. I had noted things like the console.logs should be removed. Do you remember that? Could you point me to that PR?

Hey Pablo, yes, as you noticed those comments were addressed in #356. This PR (#364) and #394 were branches of #356 each achieving different functions noted in the first comments. I then rebased #356 on each of these PRs to have one PR holding all the commits. Maybe we can close these PRs once we have #356 completed and merged?

@mkeshavarzi mkeshavarzi mentioned this pull request Oct 4, 2022
@mkeshavarzi mkeshavarzi merged commit 8b8736d into bldrs-ai:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants