New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Plan View #364
Toggle Plan View #364
Conversation
add extract hash direction from the url add a check move the ifcjs library version back to the latest debugging plane hash testing cut plane use effect move plane creating logic into the use effect debugging the model in the useEffect debugging the model in the useEffect subtract dependencies from the useEffect add model check add logs to the useEffect subtract creating plane use effect debug working on the plane in the link direction return the vector to enable cutplane change the y normal direction clean up clean up cutPlane menu deleted unused functions from the cutplane utility address order of imports clean up the cut plane utility clean up introduce toggle to the plane menu clean up calibrate normals agains the sp buildings
Demo for EISVOGEL.ifc. Integration with calLevSec.js in ifctool needed.
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Camera now toggles to the center of the model instead of (0,0,0)
efd5379
to
8b8736d
Compare
Hi Mohammed, I lost track a little. I thought I reviewed this PR, but don't see my comments. I had noted things like the console.logs should be removed. Do you remember that? Could you point me to that PR? |
Hey Pablo, yes, as you noticed those comments were addressed in #356. This PR (#364) and #394 were branches of #356 each achieving different functions noted in the first comments. I then rebased #356 on each of these PRs to have one PR holding all the commits. Maybe we can close these PRs once we have #356 completed and merged? |
Branched from #356.
Create UI button (inside ExtractLevels menu or outside) allowing the user to toggle between perspective and plan view.
Reflects #246