Clear element path on unselect #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@pablo-mayrgundter PTAL |
pablo-mayrgundter
requested changes
Sep 14, 2022
src/Containers/CadView.test.jsx
Outdated
| viewer._loadedModel.ifcManager.getSpatialStructure.mockReturnValueOnce(testTree) | ||
| const {result} = renderHook(() => useStore((state) => state)) | ||
| await act(() => { | ||
| // result.current.setSelectedElement(targetEltId) |
There was a problem hiding this comment.
These seem like good ones to add. Still WIP?
There was a problem hiding this comment.
yep totally - forgot to turn it on
OlegMoshkovich
commented
Sep 14, 2022
src/Containers/CadView.test.jsx
Outdated
| viewer._loadedModel.ifcManager.getSpatialStructure.mockReturnValueOnce(testTree) | ||
| const {result} = renderHook(() => useStore((state) => state)) | ||
| await act(() => { | ||
| // result.current.setSelectedElement(targetEltId) |
There was a problem hiding this comment.
yep totally - forgot to turn it on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #334