Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI adjustments #430

Merged
merged 6 commits into from Oct 11, 2022
Merged

Conversation

OlegMoshkovich
Copy link
Member

  • highlight open button on the first load
  • close the cutplane menu when the direction of the cut plane is selected

@netlify
Copy link

netlify bot commented Oct 8, 2022

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 8fd7630
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/6344fc8437bd5f000841f62f
😎 Deploy Preview https://deploy-preview-430--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review October 8, 2022 22:01
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that cut plane menu was causing some consternation! :)

Maybe colorize the open highlight? Green or blue?

@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter
I don't understand what you mean 'colorize the open highlight'.
But in general dark green specified in the theme is the color of choice.

@OlegMoshkovich
Copy link
Member Author

Ah yeah - colorizing the open highlight would be nice, but a bit more involved. Can do in another PR. Would be nice to get this one in.

@pablo-mayrgundter
Copy link
Member

Alright, LGTM.. would like to see color.. as noted in discussion, this doesn't really come off as a button. I think since it's near the input, it just looks like a pointer or label for that. But however you want to do it!

@OlegMoshkovich OlegMoshkovich merged commit 22984c7 into bldrs-ai:main Oct 11, 2022
@OlegMoshkovich OlegMoshkovich deleted the levels_fix branch March 29, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants