New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add accept privacy to the about dialog #437
WIP: Add accept privacy to the about dialog #437
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@MarkusSteinbrecher you brought up in the meeting that you think there's specific language we need for this dialog. Could you research and let us know? |
Document is updated with the most relevant content to update our privacy guidelines. |
I think we're still planning in the design doc. I updated it with last status from Discord. Current agreed proposal is:
|
c7b99af
to
cabfa4a
Compare
@pablo-mayrgundter @MarkusSteinbrecher please take a look at the current implementation of the cookies section. In my view it is strickly better then we have right now. I propose to merge it and continue the discussion about it, and if we agree to change it, it will be done in the separate PR. |
Heya, thanks for the change. For the label, I suggest:
|
The radio button is great. Mixed feelings about the colors though but ok ;) |
@MarkusSteinbrecher just experimenting a bit ;) |
6fee65f
to
3114e0e
Compare
3114e0e
to
ce19087
Compare
Agreed about the colors.. given a bright active color and a mute passive color, the bright color should indicate on, passive off. For the text, please call it "Analytics cookies (read more)" and link "read more" here: https://github.com/bldrs-ai/Share/wiki/Design#privacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes to the switch track, added accept cookies title, added read more link.
Looks good, but I think we want it on by default! :) EDIT: n/m.. my mistake. Looks good |
This PR mainly contains the change to the about dialog - the slider is replaced by the toggle switch.
It also contains style changes to the dialog component and some style changes to the open dialog.