Cleanup: console logging, debug and testing output, lint. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
src/Containers/CadView.jsx
Outdated
| depthTest: true, | ||
| }) | ||
| const selectMat = new MeshLambertMaterial({ | ||
| transparent: true, | ||
| color: theme.palette.highlight.main, | ||
| color: theme.palette.secondary.main, |
There was a problem hiding this comment.
this breaks high - lighting
There was a problem hiding this comment.
So the highlighting that is active in production was broken but in a different way. The console log shows the highlight color is undefined.. it was being passed in from our theme, but the theme property wasn't defined. So, I picked what looked good to me last night :) but yeah, open to any suggestions for alternatives
There was a problem hiding this comment.
This is the current selection color:
Theme.pallet.highlight.secondary or main
|
Ptal |
|
There are conflicts. |
OlegMoshkovich
approved these changes
Nov 16, 2022
pablo-mayrgundter
added a commit
to pablo-mayrgundter/Share
that referenced
this pull request
Nov 25, 2022
pablo-mayrgundter
added a commit
that referenced
this pull request
Nov 25, 2022
|
Fixes #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.