Introduce html-based AboutGuide. Normalize dialogs. Use theme. #531

pablo-mayrgundter · 2022-12-23T22:13:03Z

Use some Mui dialog components, more typography, theme support, revive dialog header icons. Move About into subfolder.

…components, typography, theme support, revive dialog header icons. Move About into subfolder.

netlify · 2022-12-23T22:13:06Z

✅ Deploy Preview for bldrs-share ready!

Name	Link
🔨 Latest commit	`b9579e6`
🔍 Latest deploy log	https://app.netlify.com/sites/bldrs-share/deploys/63dbb7730106650008a3e84b
😎 Deploy Preview	https://deploy-preview-531--bldrs-share.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

OlegMoshkovich · 2022-12-23T22:27:39Z

I don't know what state of work this is, but on the first glance a lot of elements need to be edited.

OlegMoshkovich · 2022-12-23T22:28:55Z

the dialogs don't look good with the headers.

OlegMoshkovich · 2022-12-23T22:29:41Z

why is this underline and bold?

OlegMoshkovich · 2022-12-23T22:30:20Z

this is a wrong icon.

OlegMoshkovich · 2022-12-23T22:31:17Z

b is enormous and the logo image in the middle is broken.

Fixed broken background img

…or button hover color.

OlegMoshkovich · 2022-12-23T22:33:53Z

share and about icons are smaller.

pablo-mayrgundter · 2022-12-23T22:38:23Z

this is a wrong icon.

Yep, fixed.

OlegMoshkovich · 2022-12-23T22:53:35Z

Take a look at the design dialogs
here

Maybe dialog headers can be styled differently, without the icons

pablo-mayrgundter · 2022-12-24T00:12:39Z

the dialogs don't look good with the headers.

Agreed.. I like the icon though. See what you think about moving them to left instead of above.

pablo-mayrgundter · 2022-12-24T00:13:10Z

share and about icons are smaller.

Fixed. There's now 1 place where svg sizes are set, in Share.jsx#GlobalStyles, and small X icons are className="closeButton"

…Dialog header icons to left of header text. Fix broken AboutGuide background img.

OlegMoshkovich · 2022-12-29T08:48:13Z

@pablo-mayrgundter can the operations group go back to this format?

the divider is too wide and the icons are too spaced out

The icons should be larger.

OlegMoshkovich · 2022-12-29T08:49:57Z

B disappeared from the left corner.

OlegMoshkovich · 2022-12-29T08:52:04Z

this is still not balanced. B is too big, I think, what about you?
mixed feelings about bldrs.ai underneath.

BLDRS icon in the guide graphic, it should be vertically centered.

also for this type of work, you mentioned you would like to use the storybook,
what about creating a storybook component for the about dialog and just a general dialog?

OlegMoshkovich · 2022-12-29T08:54:23Z

there is too much space between the button and the dialog content. the vertical scroll bar should not be displayed. the placement of the X is weird, maybe should be higher.

OlegMoshkovich · 2022-12-30T19:32:50Z

all of the scroll bars are green :) did you connect it to the theme?

OlegMoshkovich · 2023-01-19T21:44:42Z

@pablo-mayrgundter dialog close buttons do not work on mobile.

pablo-mayrgundter · 2023-01-27T15:57:12Z

PTAL

OlegMoshkovich · 2023-02-01T11:03:11Z

Notes Icon does not work.

OlegMoshkovich · 2023-02-01T11:04:24Z

Did slight adjustments to the graphics on on the about dialog.

pablo-mayrgundter · 2023-02-01T16:50:17Z

Did slight adjustments to the graphics on on the about dialog.

done.

pablo-mayrgundter · 2023-02-01T16:50:27Z

Notes Icon does not work.

done

pablo-mayrgundter · 2023-02-01T16:50:54Z

PTAL

OlegMoshkovich · 2023-01-06T15:45:11Z

src/Theme.jsx

+    MuiToggleButton: {
+      styleOverrides: {
+        sizeMedium: {
+          'margin': '1em',


Please change the margin to
'margin': '.2em 0em .2em 0em',

OlegMoshkovich · 2023-01-06T16:34:43Z

src/Components/Dialog.jsx

      </DialogContent>
-    </MuiDialog>)
+      <DialogActions sx={{overflowY: 'hidden'}}>


add padding to the Dialog Actions styles.
padding: '0em 0em 2em 0em'

Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>

…outControl.jsx. Add cypress scripts to package

Introduce html-based AboutGuide. Normalize dialogs: rely more on mui …

171fe7f

…components, typography, theme support, revive dialog header icons. Move About into subfolder.

pablo-mayrgundter requested a review from OlegMoshkovich December 23, 2022 22:13

pablo-mayrgundter self-assigned this Dec 23, 2022

pablo-mayrgundter added the code Code cleanup, refactoring, style and lint label Dec 23, 2022

Use open icon for open dialog header. Use theme highlight.secondary f…

f48e517

…or button hover color.

Add screenshot of 3d buildings logo in public for AboutGuide.

dc78456

pablo-mayrgundter added 6 commits December 23, 2022 19:13

Use GlobalStyles for svg sizing, fill and small control icon sizing. …

d7b7f63

…Dialog header icons to left of header text. Fix broken AboutGuide background img.

Restore theme colors to LogoB.

397aa89

merge.

7ad1b7d

Cherrypick merge fix.

cca1fa1

Lots of color normalization.

9bcf6c3

Use more of Mui Card components for notes.

42838ed

OlegMoshkovich added 2 commits January 6, 2023 19:53

style open dialog and about dialog

0e0fdca

work in progress

5e5893b

OlegMoshkovich added 3 commits January 7, 2023 12:45

adjust control icons

beaab3d

theme, fixed paths to models

c947ca3

colors and toggle

fece42c

OlegMoshkovich marked this pull request as ready for review January 8, 2023 08:41

OlegMoshkovich added 2 commits January 9, 2023 19:51

adjust the guide

d3832ea

about guide and colors

763f026

OlegMoshkovich marked this pull request as draft January 10, 2023 13:36

snackbar message

cf44590

merge

41416bb

pablo-mayrgundter marked this pull request as ready for review January 27, 2023 15:57

pablo-mayrgundter changed the title ~~Introduce html-based AboutGuide. Normalize dialogs. Refactoring.~~ Introduce html-based AboutGuide. Normalize dialogs. Use theme. Jan 31, 2023

fixes

f18b8c4

pablo-mayrgundter added 4 commits February 1, 2023 06:15

Delete #index.css#

42d19f4

Refactor drawer. Desktop working nicely

d07189b

Merge remote-tracking branch 'origin/about' into about

3a4ee38

Refactor drawer. Mobile working again.

994d114

Oleg changes to About.

f824f32

OlegMoshkovich approved these changes Feb 1, 2023

View reviewed changes

pablo-mayrgundter added 3 commits February 2, 2023 06:43

Merge branch 'main' into about

b7f0fbc

Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>

Oleg comments.

e93fc67

Fix broken homepage e2e test, remove unused old copy of Components/Ab…

b9579e6

…outControl.jsx. Add cypress scripts to package

pablo-mayrgundter merged commit f43e38b into bldrs-ai:main Feb 2, 2023

pablo-mayrgundter deleted the about branch February 6, 2023 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce html-based AboutGuide. Normalize dialogs. Use theme. #531

Introduce html-based AboutGuide. Normalize dialogs. Use theme. #531

pablo-mayrgundter commented Dec 23, 2022 •

edited

netlify bot commented Dec 23, 2022 •

edited

OlegMoshkovich commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022 •

edited

OlegMoshkovich commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022 •

edited by pablo-mayrgundter

OlegMoshkovich commented Dec 23, 2022

pablo-mayrgundter commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022 •

edited

pablo-mayrgundter commented Dec 24, 2022

pablo-mayrgundter commented Dec 24, 2022 •

edited

OlegMoshkovich commented Dec 29, 2022 •

edited

OlegMoshkovich commented Dec 29, 2022

OlegMoshkovich commented Dec 29, 2022 •

edited

OlegMoshkovich commented Dec 29, 2022 •

edited

OlegMoshkovich commented Dec 30, 2022

OlegMoshkovich commented Jan 19, 2023

pablo-mayrgundter commented Jan 27, 2023

OlegMoshkovich commented Feb 1, 2023

OlegMoshkovich commented Feb 1, 2023

pablo-mayrgundter commented Feb 1, 2023

pablo-mayrgundter commented Feb 1, 2023

pablo-mayrgundter commented Feb 1, 2023

OlegMoshkovich Jan 6, 2023

pablo-mayrgundter Feb 2, 2023

OlegMoshkovich Jan 6, 2023

pablo-mayrgundter Feb 2, 2023

Introduce html-based AboutGuide. Normalize dialogs. Use theme. #531

Introduce html-based AboutGuide. Normalize dialogs. Use theme. #531

Conversation

pablo-mayrgundter commented Dec 23, 2022 • edited

netlify bot commented Dec 23, 2022 • edited

✅ Deploy Preview for bldrs-share ready!

OlegMoshkovich commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022 • edited

OlegMoshkovich commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022 • edited by pablo-mayrgundter

OlegMoshkovich commented Dec 23, 2022

pablo-mayrgundter commented Dec 23, 2022

OlegMoshkovich commented Dec 23, 2022 • edited

pablo-mayrgundter commented Dec 24, 2022

pablo-mayrgundter commented Dec 24, 2022 • edited

OlegMoshkovich commented Dec 29, 2022 • edited

OlegMoshkovich commented Dec 29, 2022

OlegMoshkovich commented Dec 29, 2022 • edited

OlegMoshkovich commented Dec 29, 2022 • edited

OlegMoshkovich commented Dec 30, 2022

OlegMoshkovich commented Jan 19, 2023

pablo-mayrgundter commented Jan 27, 2023

OlegMoshkovich commented Feb 1, 2023

OlegMoshkovich commented Feb 1, 2023

pablo-mayrgundter commented Feb 1, 2023

pablo-mayrgundter commented Feb 1, 2023

pablo-mayrgundter commented Feb 1, 2023

OlegMoshkovich Jan 6, 2023

Choose a reason for hiding this comment

pablo-mayrgundter Feb 2, 2023

Choose a reason for hiding this comment

OlegMoshkovich Jan 6, 2023

Choose a reason for hiding this comment

pablo-mayrgundter Feb 2, 2023

Choose a reason for hiding this comment

pablo-mayrgundter commented Dec 23, 2022 •

edited

netlify bot commented Dec 23, 2022 •

edited

OlegMoshkovich commented Dec 23, 2022 •

edited

OlegMoshkovich commented Dec 23, 2022 •

edited by pablo-mayrgundter

OlegMoshkovich commented Dec 23, 2022 •

edited

pablo-mayrgundter commented Dec 24, 2022 •

edited

OlegMoshkovich commented Dec 29, 2022 •

edited

OlegMoshkovich commented Dec 29, 2022 •

edited

OlegMoshkovich commented Dec 29, 2022 •

edited