Create IFC test helper functions #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pablo-mayrgundter
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Thanks, very useful!
One concern, nanoid looks cool but isn't quite the same UUID as IFC
https://technical.buildingsmart.org/resources/ifcimplementationguidance/ifc-guid/
We already have the uuid pkg in our node_modules, so maybe just use it?
|
@pablo-mayrgundter Thanks for the heads up. That explains why in IFC project files I saw something that didn't resemble a UUID, but I incorrectly assumed it was a different library. In the future, I'll look into creating a small library that generates values that align with the IFC-GUID standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to introduce some basic helper functions to create parts of an IFC project tree structure.
Perhaps this should go into a dedicated helper directory/structure in the future as we accumulate more items like this.