Clean up Cypress E2E tests #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an open issue within the cypress-real-events library which states that the `.realHover()` function is no longer compatible with Google Chrome after version 100[1]. So we instead proceed with refactoring that test to use test IDs to match the desired HTML element. The way this failure shows up during testing is the first use of the function in question works, but any subsequent usage by other test cases within the same run will not work. However, if you retry the test run, it will give a "false positive" as long as you run within the same Cypress + Google Chrome process. False positive is in quotes because if you run it again within the same process pair, it works but if you execute on a different test runner, you will get a failure. An example of this consistent failure would be executing this test suite in GitHub Actions where each run is handled by a new test runner with a completely different process space. 1: dmtrKovalenko/cypress-real-events#247
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pablo-mayrgundter
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR originally sourced from Pablo to remove explicit timeouts and fix the improper passing of a property.
The additional change from me is to utilize a test ID for finding the Open IFC button UI element for testing rather than the previous asynchronous nature.