Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer: Selection of one or more elements via tree view #597

Merged
merged 2 commits into from Feb 20, 2023

Conversation

aozien
Copy link
Collaborator

@aozien aozien commented Feb 13, 2023

This PR closes #568

This adds the capability to select multiple elements from the side tree view

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 53d396e
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/63f14300a542fe00083ded78
😎 Deploy Preview https://deploy-preview-597--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Please add a unit test in NavTree.test.jsx.

This is a nice example of should be easy to test, but also easy to break without realizing it, so good to start testing.

@aozien
Copy link
Collaborator Author

aozien commented Feb 19, 2023

Hi @pablo-mayrgundter , I added a test for the NavTree component, the component doesn't manage it's own selection state anymore, instead, the current selected elements are all managed in the CadView component, so that's why the test is limited to the click/ shift click event, let me know what you think :)

@Adrian62D
Copy link

@aozien Will this also close #541 ?

@aozien
Copy link
Collaborator Author

aozien commented Feb 20, 2023

@Adrian62D this PR doesn't affect any widget API functionality, however, you can already use the widget API to:
1- select multiple elements
2- remove a selected element and set a new selection (deselection)
3- clear all (set selection to empty array)
the only functionality that's missing from the app and the widget is Select All

@pablo-mayrgundter pablo-mayrgundter merged commit c938098 into bldrs-ai:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

VYZN: Viewer: Selection of one or more elements via tree view
3 participants