Add page titles #632
Merged
Add page titles #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pablo-mayrgundter
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Cool!
I think also a unit test on the AboutControl.. we'll refer to that a lot.
This style looks concise
testing-library/react-testing-library#402
pablo-mayrgundter
approved these changes
Feb 23, 2023
OlegMoshkovich
pushed a commit
to OlegMoshkovich/Share
that referenced
this pull request
Mar 3, 2023
* Add React Helmet dependency * Implement Helmet context provider * Fix return type for functional component * Set titles for default page and about page * Update E2E test to check for page title * Add title for Share dialog * Add Helmet context provider for mock component wrappers * Add unit test for About dialog title * Add unit test for Share control + dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to implement dynamic page titles via the React Helmet package.
Fixes #166.