App Store Drawer #636
App Store Drawer #636
Conversation
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
wowow!
|
|
Could you please move the AppStore button into the third group, after the separator and before the Theme button. There's a typo in the Vyzn App description "environemental" -> "environmental". Could you please also add to the description smth like "- DRAFT" Also, see the screenshot.. the icon is filled in black. Is that as intended? I think something more like this? https://thenounproject.com/icon/apps-5361891/ @OlegMoshkovich thoughts? |
|
@oo-bldrs could you check this out from a security perspective? The message submission from form input makes me a little nervous but it's been ages since i've thought about code injection |
|
Might be nice to have the Vyzn App icon from the Store prefix the title when the App is active. Wdyt?
|
|
@pablo-mayrgundter I believe it makes sense to add the app icon as well, I've updated the branch |
|
This looks good. Not sure we want it live yet though. Talked with @Adrian62D today and one idea is to add a feature flag to the URL, e.g. feature=apps, and set it in the zustand store on init. So launch process would be:
|
|
Hi @pablo-mayrgundter , I've updated the branch from main, and added the feature=apps check before displaying the open app store icon, PTAL :) |
|
Let's have some more planning here.. https://discord.com/channels/853953158560743424/1090001703681658890/1098247117685932193 If we can't resolve it, let's get this merged. |
|
I had lost track of this.. @aozien you had a blocking question there. Let's try in the future to make sure any blocking issues are mentioned here. This is me doing that now TODO(pablo): answer Zien here: |
Hey Zien, I just replied in the discord... "Ok. It was a useful exercise to clean up the initial handling but I can see this being too brittle to rely on across a long session. However, this discussion stemmed from cypress testing. Now that the feature flag isn't cleared immediately, can you finish the cypress tests?" If we can get this resolved I think this PR is ready. |
This PR should close #464
To get this to work you've to first serve this file from visual studio, so that it's served on port 5500, you can also change the AppStoreData.json file to change the action to be any url(update: now it's served from local path)How storing the file data works:
1- a new property loadedFileInfo is added to the store, and gets updated when the model changes.
2- if the model was loaded from a local file we don't have to store the whole file, storing the file info is enough, and the hosted frame will be able to re-read the file from disk.
3- if the model was loaded from bldrs/share or github it will store the
How sharing the data with the app works:
Currently this implementation uses the native MessageChannel to avoid any overheads or dependencies, so that apps can integrate without having to depend on certain libraries, but that's a topic that can be open for discussion as well
The hosted frame sends an action name, and the host will respond with the same action name with the response data
And for local files
