Don't allow an anonymous user to request user organizations #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
OlegMoshkovich
pushed a commit
to OlegMoshkovich/Share
that referenced
this pull request
Mar 31, 2023
…#691) * Reject request if no authorization header provided * Correct spelling typos in test suite * Throw an exception if invoked without an access token * Create test suite for getOrganizations and additional test * Add test token to arguments * Exception is thrown before any async behavior, drop modifier * Fix shape of organizations mock object * Ensure we assert against the promise rejection (not the raw return value) * Only request a list of organizations if we're logged in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application is loaded, it unconditionally requests a list of organizations from GitHub that the logged in user is a member of. This causes an exception to be thrown every time a non-logged-in user loads the page.
This PR adds logic to reject a request for a user's organizations if we're not logged in, fixes the shape of the mock object returned during testing, and separates the tests for
getOrganizationsinto their own suite.