Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a separate highlighting functionality #703

Merged

Conversation

aozien
Copy link
Collaborator

@aozien aozien commented Mar 31, 2023

This PR should close #550

It adds a the ability to prepick elements by their Ids by code, and through Matrix API integration

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 363b779
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/643f334fda3c410008e32034
😎 Deploy Preview https://deploy-preview-703--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pablo-mayrgundter
Copy link
Member

Hi Zien, sorry for the slow review.

Please add a couple unit tests or cypress then all good.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests, then good.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Zien, just needs a merge. I tried but wasn't obvious to me

@pablo-mayrgundter pablo-mayrgundter merged commit ac4913a into bldrs-ai:main Apr 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed this week
Development

Successfully merging this pull request may close these issues.

VYZN: Matrix Widget API: Highlighting of one or more elements programmatically
2 participants