Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful handling of note loading failure #714

Merged
merged 3 commits into from Apr 25, 2023

Conversation

oo-bldrs
Copy link
Contributor

If the application fails to load comments or notes, it will display a spinner in the sidebar that never stops.

This PR addresses that scenario by introducing logic to:

  • render an application error component that gives the user the option to "restart"
  • dispatches the error to the Sentry subsystem (which will forward it along, if it's configured in that given environment).

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit e723cdd
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/6447bdf21f7a760008f89f55
😎 Deploy Preview https://deploy-preview-714--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pablo-mayrgundter pablo-mayrgundter self-assigned this Apr 25, 2023
@pablo-mayrgundter pablo-mayrgundter added the story UX task from a Milestone/Shortcut story label Apr 25, 2023
@oo-bldrs oo-bldrs merged commit a21854f into bldrs-ai:main Apr 25, 2023
7 checks passed
@oo-bldrs oo-bldrs deleted the graceful-error-on-load-failure branch May 5, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story UX task from a Milestone/Shortcut story
Projects
No open projects
Status: Closed PRs
Development

Successfully merging this pull request may close these issues.

None yet

2 participants