Perform proper URL rewriting when Git Redirector is in use #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pablo-mayrgundter
approved these changes
May 3, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IFC load request is being fulfilled, there's a small piece of logic that will rewrite the URL based on if it's a request to GitHub and the Share user is not logged in. Previously, the rewrite target was static:
raw.githubusercontent.combut that logic was changed with #716.In creating that issue (and the subsequent code review), I neglected to clarify that the entire URL should be modified appropriately as opposed to the bad logic of only replacing the host name of the target URL.
This PR fixes that logic to do the correct URL rewriting. This did not affect any users in production because it was never enabled (via setting the environment variable).