FIX: enhancing IFC isolator perf. by applying BVH trees when creating the hiding/isolation subsets #743
Conversation
…ees when creating the subset
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @Ibrahim5aad, what's the performance delta between the version without BVH trees and the one with? And does it make sense to expose this as a configurable option via the constructor, or is this something we always want to enable by default? |
Hi @oo-bldrs, without setting this flag to true, the hiding/isolation operations cause a significant decrease in the FPS ratio for the viewer sometimes I'm encountering a drop in FPS around 50%, which is causing a very laggy model navigation. Please check this video where I show by example this drop in FPS and how setting this flag to true is actually helping in better model navigation: https://www.veed.io/view/7aa3df52-7b77-47bb-bbbb-4f38a1003d3c?panel=share |
|
@ConorStokes and @nickcastel50 I'm going to start cc'ing you on some work in existing bldrs, esp performance. Here, you can go to a complex model like: And select an item by double-clicking it, then use the 'i' key to isolate it. I believe this is now faster by enabling BVH in IFCjs/Three. I'll go ahead and approve and would appreciate an LGTM just to know you're aware of this track of work as we go. |
|
@pablo-mayrgundter We experience performance problems at a client with a model spanning 4 buildings. Currently Bldrs is too slow to handle it. Would it be possible to merge this PR so that we can include this in our next release next monday? If needed it could be hidden behind a feature flag. |
LGTM |
This PR is a performance enhancement on the IfcIsolator. Applying BVH trees for the created geometry subsets seems to help with navigating the model (after applying isolation or hiding) seamlessly with the previously encountered lags.