Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property refactor #75

Merged
merged 7 commits into from
Dec 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5,014 changes: 2,514 additions & 2,500 deletions docs/index.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions docs/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "builders",
"version": "0.1.0-r215",
"version": "0.1.0-r221",
"main": "src/index.jsx",
"homepage": "https://buildrs.github.io/",
"scripts": {
Expand Down
17 changes: 9 additions & 8 deletions src/Components/AboutPanel.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import ItemProperties from './ItemProperties';
import Close from '../assets/Close.svg'


const useStyles = makeStyles((theme) => ({
const useStyles = makeStyles({
panel: {
position: 'absolute',
top: (props) => props.offsetTop,
left: 0,
right: 0,
width: '500px',
Expand All @@ -29,24 +30,24 @@ const useStyles = makeStyles((theme) => ({
height:'20px',
},
}
}));
});


const AboutIcon = () => {
const [open, setOpen] = React.useState(true);
const AboutIcon = ({offsetTop}) => {
const [open, setOpen]=React.useState(true);
return (
<div onClick={() => { setOpen(!open) }}>
About {open && <AboutPanel openToggle={()=>{setOpen(!open)}}/>}
About {open && <AboutPanel openToggle={()=>{setOpen(!open)}} offsetTop={offsetTop}/>}
</div>);
};


const AboutPanel = ({openToggle}) => {
const classes = useStyles();
const AboutPanel = ({openToggle, offsetTop}) => {
const classes = useStyles({offsetTop:offsetTop});

return (
<Paper elevation={3} className={classes.panel}>
<div className = {classes.closeButton} onClick={openToggle}><Close/></div>
<div className = {classes.closeButton} onClick = {openToggle}><Close/></div>
<h1>About</h1>
<p><strong>BLDRS</strong> is a collaborative integration environment for IFC files.
We are just getting started! Stay tuned for the upcoming MVP release.</p>
Expand Down
42 changes: 34 additions & 8 deletions src/Components/ItemPanel.jsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,21 @@
import React from 'react';
import React, {useState} from 'react';
import { makeStyles } from '@mui/styles';
import Paper from '@mui/material/Paper';
import ItemProperties from './ItemProperties';
import Close from '../assets/Close.svg'
import MenuButton from '../Components/MenuButton';


const useStyles = makeStyles(() => ({
paper: {
const useStyles = makeStyles({
toggleButton: {
position: 'absolute',
top: (props) =>`${props.topOffset}px`,
right: '20px',
},
itemPanel:{
position: 'absolute',
top: '0px',
right: '0px',
height: '400px',
width: '400px',
overflow: 'auto',
Expand All @@ -32,12 +41,29 @@ const useStyles = makeStyles(() => ({
marginRight:'10px',
cursor:'pointer'
},
}));

const ItemPanel = ({viewer, element, close}) => {
const classes = useStyles();
});

const ItemPanelButton = ({viewer, element, topOffset}) =>{
const [showItemPanel,setShowItemPanel] = useState(true);
const classes = useStyles({topOffset:topOffset});
return(
<div className={classes.toggleButton}>
<MenuButton onClick={() => setShowItemPanel(!showItemPanel)} />
{showItemPanel && <ItemPanel
viewer = {viewer}
element = {element}
close = {()=>setShowItemPanel(false)}
topOffset = {topOffset}
/>}
</div>
)
}

const ItemPanel = ({viewer, element, close, topOffset}) => {
const classes = useStyles({topOffset:topOffset});
return (
<Paper elevation={3} className={classes.paper}>
<Paper elevation={3} className={classes.itemPanel}>
<div className = {classes.titleContainer}>
<div className = {classes.title}>Properties</div>
<Close className = {classes.close} onClick = {close}/>
Expand All @@ -48,4 +74,4 @@ const ItemPanel = ({viewer, element, close}) => {
};


export default ItemPanel;
export default ItemPanelButton;
4 changes: 2 additions & 2 deletions src/Components/ToolBar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const useStyles = makeStyles((theme) => ({
}
}));

const ToolBar = ({ fileOpen, onClickShare }) => {
const ToolBar = ({ fileOpen, onClickShare, offsetTop }) => {
const classes = useStyles();
return (
<AppBar
Expand All @@ -79,7 +79,7 @@ const ToolBar = ({ fileOpen, onClickShare }) => {
</IconButton>
</div>
<div className = {classes.rightContainer}>
<AboutIcon/>
<AboutIcon offsetTop = {offsetTop}/>
<div className = {classes.profile}>{<LoginMenu />}</div>
</div>
</Toolbar>
Expand Down
28 changes: 9 additions & 19 deletions src/Containers/CadView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import { useNavigate } from 'react-router-dom';
import { IfcViewerAPI } from 'web-ifc-viewer';
import { makeStyles } from '@mui/styles';
import SearchIndex from './SearchIndex.js';
import MenuButton from '../Components/MenuButton';
import ItemPanel from '../Components/ItemPanel';
import ItemPanelButton from '../Components/ItemPanel';
import ShortCutsPanel from '../Components/ShortcutsPanel.jsx';
import NavPanel from '../Components/NavPanel';
import SearchBar from '../Components/SearchBar';
Expand Down Expand Up @@ -56,16 +55,6 @@ const useStyles = makeStyles((theme) => ({
height: '100vh',
margin: 'auto',
},
itemPanelToggleButton: {
position: 'absolute',
top: `${PANEL_TOP}px`,
right: '20px',
},
itemPanelContainer:{
position: 'absolute',
top: `${PANEL_TOP}px`,
right: '20px',
},
aboutPanelContainer: {
position: 'absolute',
top: `${PANEL_TOP}px`,
Expand Down Expand Up @@ -337,7 +326,8 @@ const CadView = () => {
<div style={{ zIndex: 100 }}>
<ToolBar
fileOpen={fileOpen}
onClickShare={onClickShare}/>
onClickShare={onClickShare}
offsetTop={PANEL_TOP}/>
<SnackBarMessage
message={loadingMessage}
open={isLoading}
Expand All @@ -354,9 +344,7 @@ const CadView = () => {
/>
)}
</div>
<div className={classes.itemPanelToggleButton}>
<MenuButton onClick={() => setShowItemPanel(!showItemPanel)} />
</div>

{showNavPanel &&
<NavPanel
viewer={viewer}
Expand All @@ -368,9 +356,11 @@ const CadView = () => {
setExpandedElements={setExpandedElements}
/>}
<div className={classes.itemPanelContainer}>
<div>{showItemPanel &&
<ItemPanel viewer={viewer} element={selectedElement} close = {()=>setShowItemPanel(false)}/>}
</div>
<ItemPanelButton
viewer={viewer}
element={selectedElement}
close = {()=>setShowItemPanel(false)}
topOffset = {PANEL_TOP}/>
</div>
<div className={classes.shortCutPanelContainer}>
{showShortCuts && <ShortCutsPanel close = {()=>setShowShortCuts(false)} />}
Expand Down