Fix icon styling across Share. Improve style setup in Cosmos. #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…le subtypes. Fix croping of Bldrs logo in About panel. Remove hardcoded fill from all SVG icons. Set fill set theme level.
…le subtypes. Fix croping of Bldrs logo in About panel. Remove hardcoded fill from all SVG icons. Set fill set theme level.
pablo-mayrgundter
changed the title
|
@OlegMoshkovich PTAL Both at Share root, and /cosmos. Linked in description |
Removing individual styles breaks visual consistency. |
…all fixtures. Upgrade svgr plugins and uniform config between esbuild and cosmos/webpack for uniform icon rendering. Simplify some components.
|
Alright, as discussed.. more fixups, and found a key issue in our svg handling. As usual, Ogali was right :) https://discord.com/channels/853953158560743424/984184622621540352/1136334718175031296 Looking good for me, but lots of changes. lmk! |
OlegMoshkovich
approved these changes
Aug 2, 2023
Signed-off-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR touches a lot of files, but accomplishes a couples simple changes:
https://deploy-preview-769--bldrs-share.netlify.app/cosmos/?fixtureId=%7B%22path%22%3A%22src%2FComponents%2FAbout%2FAboutDialog.fixture.jsx%22%7D
There are a couple import cleanups as well.