Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor visual updates #793

Merged
merged 31 commits into from Sep 28, 2023
Merged

Minor visual updates #793

merged 31 commits into from Sep 28, 2023

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Sep 26, 2023 •
edited

This PR updates

  • favicon
  • about description
  • open file dialog styles

@netlify
Copy link

netlify bot commented Sep 26, 2023 •
edited

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 884d4f2
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65153360614a3600088931ae
😎 Deploy Preview https://deploy-preview-793--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 25 (🔴 down 1 from production)
Accessibility: 84 (🟢 up 2 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pablo-mayrgundter
pablo-mayrgundter requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per convo:

  • favicon blends into bg on active tab
  • open dialog button borders aren't theme based, for logged-in user

OlegMoshkovich
OlegMoshkovich commented Sep 28, 2023
View reviewed changes
Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablo-mayrgundter PTAL

pablo-mayrgundter
pablo-mayrgundter approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OlegMoshkovich OlegMoshkovich merged commit 66d9151 into bldrs-ai:main Sep 28, 2023
7 checks passed
@OlegMoshkovich OlegMoshkovich deleted the visual_details branch February 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlegMoshkovich @pablo-mayrgundter