Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes mobile fix #796

Merged
merged 13 commits into from Oct 5, 2023
Merged

Notes mobile fix #796

merged 13 commits into from Oct 5, 2023

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Oct 1, 2023

This PR:

  • Replaces custom icons with MUI icons for notes navBar.
  • Adds extra padding on mobile for notes and properties panel to account for the browser nav bar.
  • Capitalizes the titles of the DrawerPanels.
  • Moves the placeholder of the Search bar to align with the tooltip on mobile.
  • Disables navTree expand on element select.
  • Moves the Sections menu on mobile to cover the tooltips when activated.

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit c43f13d
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/651eb8afc809180008af14fa
😎 Deploy Preview https://deploy-preview-796--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 2 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review October 2, 2023 11:06
@OlegMoshkovich
Copy link
Member Author

@oo-bldrs in this pr I subtracted expand on element select from nav panel. It feels distracting, particularly on mobile. I think it broke one of the cypress tests.
image
I re-ran the job several times.
Can you please take a look when you have a chance.

@oo-bldrs
Copy link
Contributor

oo-bldrs commented Oct 2, 2023

@OlegMoshkovich This is the test that is failing.

Does your change affect the text that is displayed in that scenario?

@OlegMoshkovich
Copy link
Member Author

OlegMoshkovich commented Oct 2, 2023

I don't think so.
I Changed the expansion of the tree on select, but the selection of the elements should not be impacted by it.

@OlegMoshkovich OlegMoshkovich merged commit 63b9edd into bldrs-ai:main Oct 5, 2023
7 checks passed
@OlegMoshkovich OlegMoshkovich deleted the notesNavBar branch February 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants