Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qr code to share dialog #797

Merged
merged 3 commits into from Oct 5, 2023
Merged

Add qr code to share dialog #797

merged 3 commits into from Oct 5, 2023

Conversation

OlegMoshkovich
Copy link
Member

This PR:

  • adds react-qr-code library
  • adds QR code to the share dialog

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 4cbddc1
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/651ec1284b3e3400084170dd
😎 Deploy Preview https://deploy-preview-797--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 25 (🔴 down 2 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL

pablo-mayrgundter
pablo-mayrgundter requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test pls.. just check that it's there.

OlegMoshkovich
OlegMoshkovich commented Oct 5, 2023
View reviewed changes
Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablo-mayrgundter added qr test - PTAL

@OlegMoshkovich OlegMoshkovich merged commit cf9ca5f into bldrs-ai:main Oct 5, 2023
7 checks passed
@OlegMoshkovich OlegMoshkovich deleted the add-qrcode-to-share branch November 8, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlegMoshkovich @pablo-mayrgundter