New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global Google Analytics and simplify privacy package. #824
Merged
pablo-mayrgundter
merged 5 commits into
bldrs-ai:main
from
pablo-mayrgundter:google-analytics
Oct 26, 2023
Merged
Remove global Google Analytics and simplify privacy package. #824
pablo-mayrgundter
merged 5 commits into
bldrs-ai:main
from
pablo-mayrgundter:google-analytics
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bldrs-share-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oo-bldrs
reviewed
Oct 25, 2023
…lyticsEnabled, isFirstTime and theme preferences.
PTAL |
@OlegMoshkovich fyi too. I apologize to both of you for the ugly cookie/privacy system before! 😬 |
pablo-mayrgundter
changed the title
Remove global Google Analytics and mock in dev mode.
Remove global Google Analytics and simplify privacy package.
Oct 25, 2023
oo-bldrs
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally by disabling msw and watching traffic in GA4 dashboard. Not showing up in netlify, but I do see netlify as a suggested domain in GA4 dashboard, so perhaps GA is just not turning itself on unless it's in a configured domain.
I suggest pushing this live and I verify it's live there.