Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network fonts. #829

Merged
merged 1 commit into from Oct 30, 2023
Merged

Conversation

pablo-mayrgundter
Copy link
Member

I had a draft (#825) setup for this change, but it got out of sync.

I don't see any significant diffs in fonts and the network load for them makes me sad. We can revisit later if we want to use something visually distinct.

Using screens from Nick and I just testing on it.

Draft PR on Mac:
image

Draft PR on Windows:
image

Prod win:
image

Prod Mac:
image

@pablo-mayrgundter pablo-mayrgundter added the code Code cleanup, refactoring, style and lint label Oct 30, 2023
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 0f05788
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65400af792360f0007c896b6
😎 Deploy Preview https://deploy-preview-829--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 0f05788
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/65400af7de8d960008d0a7c5
😎 Deploy Preview https://deploy-preview-829--bldrs-share-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-mayrgundter pablo-mayrgundter merged commit 495eee9 into bldrs-ai:main Oct 30, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code cleanup, refactoring, style and lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants