Props2, merged, cleaned up and with tests #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! |
pablo-mayrgundter
added a commit
that referenced
this pull request
Jan 27, 2022
* ItemProperties: added wiring for property sets. * package.json: always build before serve. * style property sets * properties drawer * added properties title * build * added accordians to contain sets * item properties sets * minor styles * navpanel style * turn about panel on * add tiny house to the scene * Props2, merged, cleaned up and with tests (#83) * Integrated Oleg changes from main and added unit tests for ItemProperties and updated others. * merge upstream branch, incl tiny house Co-authored-by: Pablo Mayrgundter <pablo.mayrgundter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this PR is into the feature branch on upstream. We can merge into main from there.
https://pablo-mayrgundter.github.io/Share/
Note, there's been a bug with hosting the app on our personal repos.. I have an idea how to fix this. For the time-being, it means I can't paste in a real permalink here, but you can nav and see permalink changes in the app.
I'll work on this in the upcoming URL PR.